search

casper-ecosystem / casper-js-sdk

TypeScript Casper Client SDK
Apache License 2.0
71 stars 61 forks source link

Bug in HD Key #410

Closed ryo-casper closed 2 months ago

ryo-casper commented 3 months ago

There was bug in handling seed and entropy in HD Key.

https://github.com/casper-ecosystem/casper-js-sdk/blob/e74c611bfc32b8904e8b87a692c91c981c0cbb7b/src/lib/CasperHDKeys/CasperHDKey.ts#L58

should use bip39.mnemonicToSeedSync

https://github.com/casper-ecosystem/casper-js-sdk/blob/e74c611bfc32b8904e8b87a692c91c981c0cbb7b/src/lib/CasperHDKeys/CasperHDKey.ts#L105