casper-ecosystem / casper-js-sdk

TypeScript Casper Client SDK
Apache License 2.0
71 stars 60 forks source link

Wrong bip39 function called to create seed array from word list #418

Closed TRtomasz closed 5 months ago

TRtomasz commented 5 months ago

Describe the bug i Couldnt understand why i cant get same keys using casper js-sdk as when using casper-wallet i think issue is here https://github.com/casper-ecosystem/casper-js-sdk/blob/dev/src/lib/CasperHDKeys/CasperHDKey.ts#L57 casper-js-sdk calls bip39.mnemonicToEntropy While casper-wallet calls bip39.mnemonicToSeedSync https://github.com/make-software/casper-wallet/blob/develop/src/libs/crypto/bip39.ts#L11

To Reproduce

Identify if any Prequisites:

Steps to reproduce the behavior:

  1. Go to '...'
  2. ..

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

Defect Type

ryo-casper commented 5 months ago

Duplicate of https://github.com/casper-ecosystem/casper-js-sdk/issues/410 Please check https://github.com/casper-ecosystem/casper-js-sdk/pull/413