search

casper-ecosystem / casper-js-sdk

TypeScript Casper Client SDK
Apache License 2.0
71 stars 60 forks source link

[BUG] DeployWatcher stream request are not closed properly #94

Closed KillianH closed 3 years ago

KillianH commented 3 years ago

Hi,

I'm using the new DeployWatcher and I have a problem with closing the request.

Even after stopping the deployWatcher chrome still report that the request is not yet finished and the connexion is not closed.

Do I need to implement this DeployWatcher in an API to be able to close correctly the connexion ?

hoffmannjan commented 3 years ago

Hi @KillianH

We was mainly testing the DeployWatcher in Nodejs environment, I will check it this week in a browser and let you know (and hopefully fix the issue).

Thanks for feedback 👍

KillianH commented 3 years ago

Hi @KillianH

We was mainly testing the DeployWatcher in Nodejs environment, I will check it this week in a browser and let you know (and hopefully fix the issue).

Thanks for feedback 👍

Will try to provide an example asap. I have some weird issue as sometime the deploy event is missed in the watcher ... Maybe this is due to chrome not listening if the tab is not focused or something like that.

KillianH commented 3 years ago

I'm using an EventSource now instead of the DeployWatcher and I don't have any problem.

hoffmannjan commented 3 years ago

Looks like there might be some issues in a previous version. Could you confirm that 2.4.1 fixes your issues?

KillianH commented 3 years ago

Closing this as I don't use the DeployWatcher any more on the website. However I use the EventStream for another usecase and I don't have any bug with it.