search

casper-ecosystem / cep18

Implementation of ERC20 token for the CasperLabs platform.
https://casper.network/docs/dapp-dev-guide
Apache License 2.0
27 stars 46 forks source link

Remaster erc20 into cep18 #69

Closed deuszex closed 1 year ago

deuszex commented 1 year ago
davidatwhiletrue commented 1 year ago

@deuszex, I see you already added events to this PR. Why did you choose the CEP-47 style of events instead of using the Casper Event Standard library? the latter has many benefits: the event schema is known when the contract is installed, it's cheaper, and there're already client libraries to observe and parse the events in JS, Go, and (soon) .NET. We should all try to make it the standard for the new contracts :)

Could you please consider using CES for the events? Thx

mssteuer commented 1 year ago

Seconding that.

RitaMAllenCA commented 1 year ago

There is additional work scheduled for this contract in the upcoming sprint. We will create an event modality - to follow the pattern we set in CEP 78 contracts: 3 options:

  1. no events (default)
  2. CES events
  3. 47 style events

Zoltan's first step was to clean up this contract in preparation for adding the event modality