casper-ecosystem / cep18

Implementation of ERC20 token for the CasperLabs platform.
https://casper.network/docs/dapp-dev-guide
Apache License 2.0
27 stars 46 forks source link

Miss path on wasm strip #92

Closed gRoussac closed 1 year ago

gRoussac commented 1 year ago

Hi @deuszex, there seems to be an issue with wasm strip path for the main contract, so you need to make a choice in naming unfortunately. I would advise to stop using pipe dev/null as std output because it can obfuscate a missing path and I don't see any diff as make command seems to be anyway printed, so even for people missing wasm-strip, would rather display this error right away.

make build-contract 
cargo build --release --target wasm32-unknown-unknown  -p casper-cep18  -p cep18-test-contract
    Finished release [optimized] target(s) in 0.09s
wasm-strip target/wasm32-unknown-unknown/release/casper_cep18.wasm ;  wasm-strip target/wasm32-unknown-unknown/release/cep18_test_contract.wasm ;
target/wasm32-unknown-unknown/release/casper_cep18.wasm: No such file or directory