search

casper-network / casper-node

Reference client for CASPER protocol
https://casper.network
Apache License 2.0
389 stars 219 forks source link

Share code between chainspec in testing framework and node’s chainspec #3677

Open piotr-dziubecki opened 1 year ago

piotr-dziubecki commented 1 year ago

Testing framework implements subset of ‘real’ chainspec in the node to be able to run test with a chainspec settings. This causes duplication of code, which gets harder to maintain in consistent manner. I.e. one validation step we have to add on the node side, we’d have to duplicate in testing framework. We should share as much code as possible between EE, testing framework and node. Follow up for https://github.com/casper-network/casper-node/pull/3665#discussion_r1102827436

RitaMAllenCA commented 1 year ago

@rafal-ch I know Karan made some changes to have the test support crate read from a chainspec. I wonder if his work makes this more straightforward? I assigned this to you, but please assign to someone else if appropriate. Thanks

NO - this has not been done

RitaMAllenCA commented 1 year ago

Best to do this in casper_types or other crate. "Decouple our types"