casper-network / casper-node

Reference client for CASPER protocol
https://casper.network
Apache License 2.0
393 stars 223 forks source link

Introducing seigniorage proportion gauge #4956

Closed AlexanderLimonov closed 2 days ago

AlexanderLimonov commented 2 weeks ago

4935

Introduces a crude gauge of reward trajectory adherence

AlexanderLimonov commented 1 week ago

@darthsiroftardis

Tests failing with integer overflows due to a cast to u128

thread 'reactor::main_reactor::tests::rewards_are_calculated' panicked at /home/alexlimonov/CasperLabs/casper-node/types/src/uint.rs:41:5:
Integer overflow when casting to u128

failures:
    reactor::main_reactor::tests::dont_upgrade_without_switch_block
    reactor::main_reactor::tests::historical_sync_with_era_height_1
    reactor::main_reactor::tests::network_should_recover_from_stall
    reactor::main_reactor::tests::node_should_rejoin_after_ejection
    reactor::main_reactor::tests::rewards_are_calculated
    reactor::main_reactor::tests::run_network
    reactor::main_reactor::tests::run_withdraw_bid_network
    reactor::main_reactor::tests::should_not_historical_sync_no_sync_node
    reactor::main_reactor::tests::should_raise_gas_price_to_ceiling_and_reduce_to_floor_based_on_gas_consumption
    reactor::main_reactor::tests::should_raise_gas_price_to_ceiling_and_reduce_to_floor_based_on_size_consumption
    reactor::main_reactor::tests::should_raise_gas_price_to_ceiling_and_reduce_to_floor_based_on_slot_utilization
    reactor::main_reactor::tests::transactions::fee_is_accumulated_and_distributed_no_refund_classic_pricing
    reactor::main_reactor::tests::transactions::fee_is_accumulated_and_distributed_no_refund_fixed_pricing
    reactor::main_reactor::tests::transactions::sufficient_balance_is_available_after_amortization
    reactor::main_reactor::tests::transactions::transfer_cost_fixed_price_no_fee_no_refund

Two real options, one is to actually do something about the integer types (hard) or investigate the stake sizes and growth rates being used for these tests and adjust them to something reasonable. Not ideal, but a lot easier. Or else some third way of avoiding a panic in the metric calculation.

EdHastingsCasperAssociation commented 2 days ago

bors r+

casperlabs-bors-ng[bot] commented 2 days ago

Build succeeded: