search

casper-network / casper-python-sdk

Python library for interacting with a CSPR node
Apache License 2.0
14 stars 19 forks source link

No return in get_dictionary_item #6

Closed sisco0 closed 2 years ago

sisco0 commented 3 years ago

Why is there no return statement in the function attached below?

https://github.com/casper-network/casper-python-sdk/blob/main/pycspr/api/get_dictionary_item.py

MrKrautee commented 2 years ago

I see a return value. only in case the exception is raised there is non.

sisco0 commented 2 years ago

Yes, the return expression is now expressed with a return clause. That was not the case when the issue was open in https://github.com/casper-network/casper-python-sdk/blob/2f2df0bea6d61fd63c64c418e6e2e7481b63c069/pycspr/api/get_dictionary_item.py

The issue could be closed as now it complies with the requirement.