casper-network / casper-sidecar

Apache License 2.0
2 stars 8 forks source link

Remove 'juliet' from the RPC sidecar #289

Closed rafal-ch closed 5 months ago

rafal-ch commented 5 months ago

This PR changes the communication method of the binary port from 'juliet' to tokio framed transport.

The corresponding PR on the node side: PR.

jacek-casper commented 5 months ago

One additional minor comment: the code is still using a RwLock, but it's only used in write mode, so it offers no advantage over a Mutex