casper-network / casper-sidecar

Apache License 2.0
2 stars 7 forks source link

Fix historical auction queries in the sidecar #308

Closed SaiProServ closed 1 month ago

SaiProServ commented 1 month ago

Sidecar fails to look up the auction state if it was stored by <=1.3 version of the node before an upgrade (discovered in NCTL upgrade test 12). There are two reasons for it, one is that in that version we didn't have a contract registry in global state so the sidecar fails to find it (we need to update the sidecar to look for this registry under the latest state root hash instead), and second is that the values behind the contract registry at the time would've been legacy contracts instead of addressable entities, so we'll need to explicitly handle that in the sidecar.