This PR serves as a detailed editing pass of the emulation document. Also, I found some things that are unclear and need to be checked:
For Translating Write transforms, there seems to be a copy/paste error for ContractPackage. See the TODO.
Why do we have protocol_version: 1.0.0 for the Version2 block? This seems incorrect in this example. See block_hash 2df9fb8909443fba928ed0536a79780cdb4557d0c05fdf762a1fd61141121422.
The following seems incorrect. See the proposed change for this section:
All V2 events will be omitted from legacy SSE event streams. For example, the following event will not be streamed.
"TransactionAccepted": {
"Version1": {
...
I think we should use “Version1” and “Version2” instead of V1 and V2, to match the event content.
If possible, I would reduce the focus on “Version1” events in the examples since this seems to be a very rare case during a network upgrade.
This PR serves as a detailed editing pass of the emulation document. Also, I found some things that are unclear and need to be checked:
For Translating
Write
transforms, there seems to be a copy/paste error for ContractPackage. See the TODO.Why do we have protocol_version: 1.0.0 for the Version2 block? This seems incorrect in this example. See block_hash 2df9fb8909443fba928ed0536a79780cdb4557d0c05fdf762a1fd61141121422.
The following seems incorrect. See the proposed change for this section:
I think we should use “Version1” and “Version2” instead of V1 and V2, to match the event content.
If possible, I would reduce the focus on “Version1” events in the examples since this seems to be a very rare case during a network upgrade.