search

casper-network / cctl

Bash application to work with a local casper-node network.
MIT License
4 stars 5 forks source link

Docker image is NOT built using local source #20

Closed koxu1996 closed 2 months ago

koxu1996 commented 2 months ago

I was surprised to see that Dockerfile is not at the root location - how CCTL scripts are included then? In theory it could be done by setting build context, however it is done differently: CCTL source is cloned directly from github :frowning:.

https://github.com/casper-network/cctl/blob/7bff3a4add64aeb6ce7641ee5e48cf94afa34383/docker/Dockerfile#L31-L32

This is definitely wrong.

koxu1996 commented 2 months ago

It also affects caching, as new changes to CCTL will never be picked up (unless whole cache disabled for build).