search

casper-network / condor-info

Casper 2.0 technical outreach
Apache License 2.0
3 stars 2 forks source link

[Condor-Release]: No gas_price_tolerance check in transaction acceptor #71

Closed davidatwhiletrue closed 1 month ago

davidatwhiletrue commented 1 month ago

Category

Possible Bug

Your email address

Project Name(Optional)

MAKE

Casper Network

Devnet

Priority

Low

Node Functionality

Node

Description

The node accepts a transaction with a gas_price_tolerance value lower than min_gas_price in the chainspec. For instance, these transactions have the value 0. 

casper-client get-transaction -n http://3.20.57.210:7777/rpc 5e8cf89c188f77a599241041da8420e5e7d45e84c5be587d01a70f375cd28174
casper-client get-transaction -n http://3.20.57.210:7777/rpc cc1fc297951ee177350551250a016f920a3022bff050542e46e83fc9cbb97c48

They're neither executed nor rejected. After expiration, no error in the execution_info can be seen. Shouldn't the TransactionAcceptor reject the transaction?

Date Issue Began(optional)

18/07/2024

Attachments (optional)

No response

cspramit commented 1 month ago

https://github.com/casper-network/casper-node/pull/4814