[Condor-Release]: EraEndV2.rewards type definition in the schema does not match actual response

[davidatwhiletrue]

Category

Integration Issue

Your email address

-

Project Name(Optional)

MAKE

Casper Network

Devnet

Priority

Low

Node Functionality

JSON RPC

Description

The RPC schema defines EraEndV2.rewards property as

            "rewards": {
              "description": "The rewards distributed to the validators.",
              "type": "object",
              "additionalProperties": {
                "type": "array",
                "items": {
                  "$ref": "#/components/schemas/U512"
                }
              }
            },

However, the actual response from the node is a BTreeMap<PublicKey, Vec<U512>>:

Date Issue Began(optional)

25/07/2024

Attachments (optional)

No response

[cspramit]

@melpadden if you reproduce this please update here - we will take a look

[jacek-casper]

@davidatwhiletrue I think this response does align with the schema, this type:

"rewards": {
  "description": "The rewards distributed to the validators.",
  "type": "object",
  "additionalProperties": {
    "type": "array",
    "items": {
      "$ref": "#/components/schemas/U512"
    }
  }
},

corresponds to an object of arrays of U512, I double checked it in a swagger editor and it seems to align with that:

[davidatwhiletrue]

hey @jacek-casper . You're right. I didn't realize the array of U512 is inside the additionalProperties and not describing the content of the rewards object. This issue can be closed. Thanks.