casperdcl / git-fame

:star: Pretty-print `git` repository collaborators sorted by contributions
Other
641 stars 34 forks source link

excl appears to have no effect #89

Open tredeske opened 1 year ago

tredeske commented 1 year ago

Using the containerized version (podman on linux), --excl appears to have no effect on loc or other stats.

$ podman run --rm -it --userns=keep-id -v /path/to/myrepo:/repo:Z casperdcl/git-fame -s --since 91.days --cost cocomo -M -C --excl='.*' --loc 'ins,del'

$ podman run --rm -it --userns=keep-id -v /path/to/myrepo:/repo:Z casperdcl/git-fame -v
2.0.1

$ git --version
git version 2.31.1

Exclusions tried:

Using -n with explicitly listed files also fails to exclude.

Using --log=DEBUG verifies that the regex was received by git-fame as expected.

Using --incl='regex' also appears to have no effect. Examples:

ntcong commented 1 year ago

if you use any loc other than surv, the excl parameter got ignored

twam commented 1 year ago

Maybe something worth mentioning on --help. :)

tredeske commented 8 months ago

An update to the cmdline help would be useful, as would emitting an error if loc conflicts with excl. Better would be enabling excl to have an effect regardless of loc.