search

casperin / nod

Plugin that gives you frontend validation for forms.
http://casperin.github.io/nod/
381 stars 137 forks source link

updated for Bootstrap 3 and put version number into nod filename during build #84

Closed SingingBush closed 9 years ago

SingingBush commented 10 years ago

have also removed the lib folder which used to have bootstrap. no need to keep in repo as can use the bootstrap that is downloaded via Bower.

casperin commented 9 years ago

Hey @SingingBush. These are some pretty big changes! I (obviously) haven't been working on this for ages; and I can just merge the pull request "as is". Should I?

I literally just rebuilt nod, without dependencies, and without focusing on bootstrap. No grunt, or anything. Just a nod.js file. I like it way more than this coffee/jquery/bootstrap beast.

Check out branch "2".

My idea is to merge it in soon'ish. Once I have a bit more confidence in it. But until then, I don't mind pushing your changes. :)

SingingBush commented 9 years ago

it's not changing as much as it looks. bumping the bootstrap version (and therefore changing the css classnames that it looks for) and then running with the version that gets pulled in rather than having a copy in the repo. The date bit is the only thing that is really new and that is minimal, maybe could do a little more with it but that was all I needed.

It should be safe to pull in if things are the same as when I made the changes.

casperin commented 9 years ago

I believe they are. I'll just merge :)