Naming - Githubissues

casperkaae / parmesan

Variational and semi-supervised neural network toppings for Lasagne

Other

208 stars 31 forks source link

Naming #28

Closed skaae closed 8 years ago

skaae commented 8 years ago

Adds multinomial cost (please check :))
rename mu to mean across all classes. This matches numpy.
use 'log_var' in all classes
Fix typo in confusion matrix batchaddmasked method
some pep8 changes.

casperkaae commented 8 years ago

I agree that this is a better naming.

I'll Merge unless you have further changes?

skaae commented 8 years ago

unrelated note: What linewidth do you use? I think we should try to stick with 80

skaae commented 8 years ago

@wuaalb: Thanks. I was too sloppy :)

squased the commits

casperkaae commented 8 years ago

Looks good :) Any further changes otherwise i'll merge later tonight ?

skaae commented 8 years ago

While we are at various fixes: Maybe we should reverse the order in the confusion matrix such that it correpsonds to the cost functions i.e some_function(model_pred, true_value). The confusion matrix has the order reversed.

https://github.com/casperkaae/parmesan/blob/master/parmesan/utils.py#L56

casperkaae commented 8 years ago

I'll merge this one now and fix the confusion matrix together with #29