search

casperklein / docker-netbox-scanner

10 stars 7 forks source link

DNS column doesn't populate #6

Closed razaahmed closed 1 year ago

razaahmed commented 1 year ago

I tried ./scan --dns 10.10.2.2 (MY DNS IP) and make sure dig -x 10.1.2.3 @10.10.2.2 is able to resolve both, reverse and forward lookup. but it doesn't fill up DNS column on netbox but it does add a description with a proper DNS name. not filling in the right column that is the DNS Name.

casperklein commented 1 year ago

it does add a description with a proper DNS name

Then you got it "working". That's how netbox-scanner implemented it:

https://github.com/lopes/netbox-scanner/blob/d31633a44f6a46b9622692868f0e69c0b7c6fef5/nbs/__init__.py#L68-L69

I am not very familiar with python, but I'll try to provide a fix for this.

razaahmed commented 1 year ago

Thank you. it looks like it was there but commented out and replace with a description.

casperklein commented 1 year ago

Should be fixed now.