search

casperklein / homeassistant-addons

Home Assistant Add-on Repository
23 stars 3 forks source link

Bookmarks configuration does not work anymore after YCast 1.1.5 update #22

Closed mvdwetering closed 2 months ago

mvdwetering commented 2 months ago

Add-on name YCast 1.1.5

Describe the bug

The bookmarks I had in my configuration are not working anymore. Home Assistant seems to indicate the format is invalid. Also copy-pasting the example from the README.md does not work and gives the same error.

To Reproduce

Steps to reproduce the behavior:

  1. I think it was something like this
  2. Make a bookmarks configuration in previous version
  3. Upgrade to 1.1.5
  4. Bookrmarks not working

I did notice some kind of error when updating, but then I tried to fix the configuration by resetting the configuration to defaults and now I can't get the bookmarks back in.

Expected behavior

Bookmarks configuration keeps working after update or instructions on how to migrate to a new format.

Screenshots

image

This is the error I see when trying to save the configuration. It translates to "Failed to save addon configuration: not a valid value. Got { 'bookmarkd': etc..."

Additional context

My configuration that worked before:

bookmarks:
  - "Rock Antenne: http://mp3channels.webradio.rockantenne.de/rockantenne"
  - "NPO Radio 1: https://icecast.omroep.nl/radio1-bb-mp3"
  - "NPO Radio 2: https://icecast.omroep.nl/radio2-bb-mp3"
  - "3FM: http://icecast.omroep.nl/3fm-bb-mp3"
  - "NPO Radio 4: https://icecast.omroep.nl/radio4-bb-mp3"
  - "NPO Radio 5: https://icecast.omroep.nl/radio5-bb-mp3"
  - "Radio 538: https://25283.live.streamtheworld.com/RADIO538.mp3"
  - >-
    Radio 10:  
    http://playerservices.streamtheworld.com/api/livestream-redirect/RADIO10.mp3
  - "Qmusic: https://icecast-qmusicnl-cdp.triple-it.nl/Qmusic_nl_live_96.mp3"
  - "SLAM!: http://stream.slam.nl/slam"
  - "100% NL: http://stream.100p.nl/100pctnl.mp3"
  - >-
    KINK:
    https://playerservices.streamtheworld.com/api/livestream-redirect/KINK.mp3
  - "Arrow Classic Rock: http://stream.gal.io/arrow"
  - "BNR Nieuwsradio: https://stream.bnr.nl/bnr_mp3_128_20"
  - "Sky Radio: https://22663.live.streamtheworld.com/SKYRADIO.mp3"
  - >-
    Radio Veronica:
    https://playerservices.streamtheworld.com/api/livestream-redirect/VERONICA.mp3
casperklein commented 2 months ago

I think, this commit is the cause. I've reverted that change and will release version 1.1.6 shortly.

PS: Nice to see, that with the exception of me, other people are still using this addon 🚀

casperklein commented 2 months ago

You can now try version 1.1.6 👍

kovu94 commented 2 months ago

Of course and thank you for the fast fix. I'm using it for my old Yamaha amp and struggled also after the last update. Now it's working fine again. Thanks for supporting it and keeping older amps working :-)

casperklein commented 2 months ago

@mvdwetering I close this issue. Let me know, when the issue is not resolved for you.

mvdwetering commented 2 months ago

Sorry for late reply, thanks for fixing the issue. The bookmarks get stored again 👍

kovu94 commented 1 month ago

Also works perfectly in my installation :-)