search

cass-degrees / CASS-Degrees-Code

Primary Codebase for the TechLauncher CASS Degrees project
4 stars 1 forks source link

Fix caching issues #420

Closed JackSekoranja closed 5 years ago

JackSekoranja commented 5 years ago

Closes #230

Adds verification to created CSS and JS files to ensure the latest versions are available. This PR will add a version number to each file (set by the last edited time) so that if the server tries to access a CSS/JS file that has been updated, it won't be able to find it in the cache. However, if the file has not changed, it will be able to find it, and will use that file instead. Since you can't send headers when you load CSS or JS, this approach is commonly used.

NOTE: This was only done to our files, so files like vue.js will be cached as normal.

pep8speaks commented 5 years ago

Hello @JackSekoranja! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-09-30 01:13:27 UTC