search

cass-degrees / CASS-Degrees-Code

Primary Codebase for the TechLauncher CASS Degrees project
4 stars 1 forks source link

Modify PDF styling to improve various aspects of display #425

Closed j-selby closed 5 years ago

j-selby commented 5 years ago

Closes #385.

Closes #442.

Should close #440.

(Another big one, sorry!)

This PR fixes a few issues with PDF styling to improve both the overall layout and to improve fonts/consistency.

Firstly, this fixes issues with OR rules rendering multiple course boxes for all the branches. This now renders this as one. This does remove any pre-filled values from the template, though these are now listed as part of the rule description itself when this occurs.

Student filled values will still fill as per normal (note the changes as well to the student-facing frontend to fix that there as well).

The top title has been tweaked to maximise space, noting that if a student put in a really long title this would cause issues. This provides (at least) a little more space there.

Breaks between boxes has been removed, noting that a smaller plan was preferred in testing (ideally, one page). Further, we now render 4 columns (rather than 3) as this doesn't really affect readability and allows us to get more course boxes onto the page. Page margins have also been tweaked.

Edit: Sample image: DaringIssue

Jack's Edit: Will also Close #416, as through testing this PR seems to remove the bug

pep8speaks commented 5 years ago

Hello @j-selby! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-10-03 08:31:47 UTC