search

cass-degrees / CASS-Degrees-Code

Primary Codebase for the TechLauncher CASS Degrees project
4 stars 1 forks source link

Update Bulk Uploader to support excel file format generated by Course Report #426

Closed Daniel-Jang closed 5 years ago

Daniel-Jang commented 5 years ago

Original Issue: #415

The bulk uploader has been modified to support the excel sheet format generated by the course report page.

Also, modified the bulk uploader to also accept the 'currently active' flag, instead of outright ignoring courses that are currently 'inactive'. This change has been extended to when CASS files are being read, which means that courses marked for "disestablishment" will no longer be ignored, but added with "currentlyActive" flag set to false.

CASS Degrees Excel Sheet (For reference): CASS-3-year-teaching-plan-2019-to-2021-Finalwith-course-convenor-addresses.xlsx

Test this PR with the following file: Course Report Excel Sheet (Fixed version, identical format to generated excel sheet): Course Report Fix.xlsx

NOTE: I have found a bug where uploading the excel file generated by the Course Report page causes the openpyxl library to raise "BadZipFile" error, which will be dealt with in a separate issue. Edit: Issue has been created: #427

pep8speaks commented 5 years ago

Hello @Daniel-Jang! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-10-01 13:15:29 UTC