search

cass-degrees / CASS-Degrees-Code

Primary Codebase for the TechLauncher CASS Degrees project
4 stars 1 forks source link

Truncate courses in course lists in PDFs to avoid filling up entire page #456

Closed j-selby closed 5 years ago

j-selby commented 5 years ago

Closes #349

This PR truncates courses in course lists to prevent issues where a large course list can consume way too much space. It would be much more preferable for students to consult P&C in these cases as it isn't feasible to communicate all possible course combinations in templates.

Preview: VacantCloud

joshcbee commented 5 years ago

What sort of difficulty would we be looking at to have the lists print on a second page with a list title, then refer to, e.g. Complete 6 units from Methods Courses 1.

From a usage point of view, I think we run into the same issue we ran into with deleted courses with the 'and 5 more'. If I don't have a way to readily check what those are, the list as a whole is of no use unless I have done exactly those 5 courses listed, and it doesn't help me with where to go next.

What do you think James?

j-selby commented 5 years ago

@joshcbee I'll take a look at outputting course lists onto another page. The argument here was that they are going to need to look at programs and courses at some point anyway - the PDF tool has always been to help students make sure they are ticking boxes, not to replace what is available on P&C (as it isn't realistically possible to encapsulate all information).

pep8speaks commented 5 years ago

Hello @j-selby! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-10-10 23:55:46 UTC