search

cass-degrees / CASS-Degrees-Code

Primary Codebase for the TechLauncher CASS Degrees project
4 stars 1 forks source link

Student portal page for end of project #458

Closed KavsHub closed 5 years ago

KavsHub commented 5 years ago

Issue: #341 (Basic student portal for end of Semester 2)

Initial commit (Work in progress)

Currently accessible by: {HOST_IP}/portal

Pretty much follows the same style we currently have for the student planner except when you click on the program it takes you to the pdf template for the plan in a new tab.

image

image

I'm trying to add pagination to it now so that it doesn't load 100 programs on one page.

Open to feedback and naming changes. (Wasn't sure what we wanted to call the page so it's called 'portal' for now)

I also call the staff pdf function, should make a student version for it? or it is safe doing what I'm currently doing? (I've tested and it works when you're not logged in)

KavsHub commented 5 years ago

I might also group programs by year like the way its currently done on CASS's website

pep8speaks commented 5 years ago

Hello @KavsHub! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 6:121: E501 line too long (122 > 120 characters)

Comment last updated at 2019-10-09 12:23:28 UTC
KavsHub commented 5 years ago

Pagination has been added. + other small things that were mentioned and discovered.

Link from homepage image Pagination (10 per page) image

EDIT I realised the django pagination broke the fuzzy search... looking into it now

KavsHub commented 5 years ago

Okay cool I'll switch the pages and URLs around.

KavsHub commented 5 years ago

Okay, the student portal is now the new index.html and I've added authentication to all the student planner (prototype) pages. - Access by going to /prototype

KavsHub commented 5 years ago

Issue of security of unpublished plan pdf viewing raised by @j-selby has been solved. I've now added a login check if trying to view an unpublished plan.