Port extension to Gnome version 46

cass00 / enhanced-osk-gnome-ext

Enhanced On-Screen Keyboard for Gnome Shell

http://extensions.gnome.org/extension/6595/enhanced-osk/

21 stars 9 forks source link

Port extension to Gnome version 46 #15

Open brunnseb opened 4 months ago

brunnseb commented 4 months ago

Addresses #14

Updated all osk layouts to use strings for levels instead of numbers
Updated code wherever needed to address internal API changes to ui/keyboard.js
Removed logic for caps_lock on long press shift as this is now default behavior in Gnome 46

As this is a breaking change to the extension and will only work on Gnome 46 I'm not sure how you want to proceed. Should there be a separate release branch for this new version or how do you usually handle backwards compatibility?

cass00 commented 3 months ago

Seems like I missed the pull requests. I have not tested this but the code changes look good to me. Good work I'll merge it tomorrow into master and create a gnome 45 branch for the older version. Stay tuned.

cass00 commented 3 months ago

I had a closer look now. Tested your version with qemu.

The caps lock logic was added for a reason. See commit a8a48fec1e848026609636f5ae6af1979c436e5d and 28d23adce177e44ef499577e5300514546e8e628. In the current state caps lock on long press does not work for me, most likely because of the changes in json file in commit a8a48fec1e848026 .
Another problem is that modifiers are disabled on level change. Therefore key combinations like Alt-F2 won't work. I think you added this._disableAllModifiers(); in _setActiveLevel which causes this problem.

This issues should be addressed, before merging this into master.

brunnseb commented 3 months ago

@cass00 Thanks for the review, I will have a look at these points in the next few days....

teohhanhui commented 3 months ago

The panel indicator should be hidden when the "Screen Keyboard" accessibility feature is off, as it'd then do nothing and serve no purpose.

EDIT: Actually I have noticed the current behaviour causes the enabling - disabling - enabling cycle to not work properly:

Error: Extension point conflict: there is already a status indicator for role OSKIndicator

brunnseb commented 2 months ago

Sorry for the inactivity on this, I've been out the past few weeks with health issues. I'll try to have a look in the upcoming days but no guarantees as I'm still recovering 🤕

hubick commented 3 days ago

Copy/Paste menu in Chromium doesn't work via touch on my tablet. Gnome settings doesn't allow mapping a key to copy/paste functionality. Gnome OSK has no "ctrl" key to type "ctrl+v". I'm dying here lol. I'd love to see this extension work on Gnome 46.