search

cassandre-tech / cassandre-trading-bot

Create your Java crypto trading bot in minutes. Our Spring boot starter takes care of exchange connections, accounts, orders, trades, and positions so you can focus on building your strategies.
https://trading-bot.cassandre.tech
GNU General Public License v3.0
584 stars 166 forks source link

update to spring boot 3 #1258

Open fer-marino opened 9 months ago

fer-marino commented 9 months ago

I've noticed that this project still uses spring 2.7, which unfortunately has been discontinued. Would be nice to rebase on spring boot 3!

Just forcing the dependency doesn't seems to work unfortunately. Thanks for your work

straumat commented 9 months ago

@fer-marino thanks for your issue. I will try to take time to do it!

xerikssonx commented 3 weeks ago

"Hi, thanks for all your hard work on Cassandre—it's been incredibly helpful! I was wondering if you have any plans to update it to Spring Boot 3, as I'd be interested in using the new features."

straumat commented 3 weeks ago

HI @xerikssonx and thanks, i will try to find some time in december

xerikssonx commented 2 weeks ago

@straumat could you please allow me create branches and pull requests, I working on migration to Spring boot 3

straumat commented 2 weeks ago

 @xerikssonx Hi ! I think you can create a fork and ask for me to merge your work once you are done ?

xerikssonx commented 2 weeks ago

@straumat done https://github.com/cassandre-tech/cassandre-trading-bot/pull/1310

straumat commented 2 weeks ago

@xerikssonx Thanks ! I try to review it this week. Just one question : why do you remove ZonedDateTime ?

xerikssonx commented 2 weeks ago

@straumat it did not work with ZonedDateTime. But I check fix that I've added for OffsetDateTime works also with ZonedDateTime. So I reverted changes to ZoneDateTime back. Could you pleasetrigger build again? Also pay attantion, I change expecting in one test to code 401 from 403 (authentication.test.js).

xerikssonx commented 1 week ago

@straumat hi, are you going to create new release with spring boot 3?

straumat commented 1 week ago

@xerikssonx Hi ! Yes, but i need to fix some issues with my key :)

xerikssonx commented 15 hours ago

@straumat, I found bug with spring boot 3. https://github.com/knowm/XChange/issues/4930 it's repoducable on version with spring boot 3. Please don't create new release till I fix it