search

cassava / repoctl

Make it easy to manage your local Arch Linux repository.
MIT License
125 stars 14 forks source link

Do not hardcode paths #70

Closed JustTNE closed 1 year ago

JustTNE commented 1 year ago

Do not hardcode binary paths such as repo-add and repo-remove. This is important when building this package on a non FHS system. (Specifically, this was tested on NixOS)

cassava commented 1 year ago

Without looking too much into it at the time, I hardcoded the paths because I wanted to be conservative on issues that could be security vulnarabilities until a use-case arose.

The usage in repoctl seems ok though.

cassava commented 1 year ago

Thanks for your contribution, @JustTNE.

JustTNE commented 1 year ago

No worries! We use this package extensively at chaotic-aur, so it's only fair to contribute stuff we use ourselves back :)

cassava commented 1 year ago

I'm glad to hear it's useful to you! I wish I had more time to work on it, but I only have a little. Do you need a new release to take advantage of this PR?

Technetium1 commented 1 year ago

@cassava No need :smiley: