Built-in stack unwinder does not compile correctly on Ubuntu 8.10 x86_64 (gcc 4.3.2)

[GoogleCodeExporter]

Attempting to build using the "native" stack unwinder on Ubuntu 8.10 x86_64
fails with an unknown definition for "memset".  This is attempted the
normal way - with NO_FRAME_POINTER defined, no libunwind installed, and
line 72 of stacktrace.cc changed to "#elif 1".

The problem is that the memset function is no longer defined by the headers
this file includes, and now string.h must also be included explicitly.

I expect that this is really a problem with GCC 4.3+ on any platform.

The attached patch modifies stacktrace_x86_64-inl.h to fix this issue. 
(Note: the patch *does not* modify stacktrace.cc as above.)

Original issue reported on code.google.com by roger.a....@gmail.com on 24 Feb 2009 at 5:47

Attachments:

• ubuntu-fix.patch

[GoogleCodeExporter]

Oops -- sorry about that!  I'll have that fixed for the next release.

Original comment by csilv...@gmail.com on 24 Feb 2009 at 7:39

• Changed state: Started
• Added labels: Priority-Medium, Type-Defect

[GoogleCodeExporter]

This should be fixed in perftools 1.1, just released.

Original comment by csilv...@gmail.com on 11 Mar 2009 at 9:20

• Changed state: Fixed