search

casseopea2 / gperftools

Automatically exported from code.google.com/p/gperftools
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

bad ifdef disables intended malloc hook override in heap_checker #29

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
heap_checker.cc has
#ifdef HAVE___ATTRIBUTE___
in front of the code to override the initial malloc hooks.
but the define that is made when attributes are available is one underscore
shorter: HAVE___ATTRIBUTE__

so the initial malloc_hook override never occurs on any platform.
this can lead to bad answers from the heap checker if it then misses early
calls to sbrk or mmap.

Original issue reported on code.google.com by mslev...@akamai.com on 8 Oct 2007 at 4:15

GoogleCodeExporter commented 9 years ago 
Good call!  Will be fixed for the next release.

Original comment by csilv...@gmail.com on 8 Oct 2007 at 4:24

GoogleCodeExporter commented 9 years ago 
Fixed in perftools 0.94

Original comment by csilv...@gmail.com on 29 Nov 2007 at 11:47