search

cassidyjames / ephemeral

A private-by-default, always-incognito browser for elementary OS
https://cassidyjames.com
GNU General Public License v3.0
154 stars 22 forks source link

Improve translation #211

Closed NathanBnm closed 4 years ago

NathanBnm commented 4 years ago

I removed untranslated files to avoid confusion. I also split the metadata translation from the main one.

This PR is ready for review

cassidyjames commented 4 years ago

@NathanBnm thanks for this! I have mixed thoughts on the untranslated files; I think I need to update the translation README if we drop those to tell people how to add their own language. I'll ask around how other app authors feel about that.

Could you please fix conflicts?

NathanBnm commented 4 years ago

Sure I'll do that.

I think it's better to only keep available translations because when a language is not available, we can notice it immediatly.

I'ts more clear too to separate the metadata translations from the main ones.

I can work around it if you want. I already seen it in other repos.

NathanBnm commented 4 years ago

I have resolved the conflicts and updated French translation.

NathanBnm commented 4 years ago

@cassidyjames maybe you could take example on @lainsce like here https://github.com/lainsce/khronos/tree/master/po

However, I think further instruction is needed on how to create a PR

fitojb commented 4 years ago

Isn’t it better to create focused PRs and not include drive-bys like updating translated strings?

fitojb commented 4 years ago

(IMHO)

NathanBnm commented 4 years ago

@fitojb you're right. I'll think about it for my future PRs.