Browser button icons are too-big on non-elementary platforms

cassidyjames / ephemeral

A private-by-default, always-incognito browser for elementary OS

https://cassidyjames.com

GNU General Public License v3.0

154 stars 22 forks source link

Browser button icons are too-big on non-elementary platforms #232

Closed cassidyjames closed 4 years ago

cassidyjames commented 4 years ago

It looks like they're currently always 24, but should be 16 on non-elementary.

https://github.com/cassidyjames/ephemeral/blob/5be06875e9f9792ea1ae5ae27c2873a7103be177/src/Widgets/BrowserButton.vala#L134-L138

alice-mkh commented 4 years ago

Ah, makes sense. Really you should probably use the size property here, i.e. toolbar/menu etc one. Then you set toolbar for elementary, button otherwise.

cassidyjames commented 4 years ago

I'm doing that for the other icons (and here; see line 136), but iirc I am also explicitly setting the pixel size due to a bug where Firefox icons would sometimes show up as huge or something (we've seen this in menus in Code, at least). When dealing with app-provided icons I think it was just safer to (also) explicitly set the pixel size.