cassidyjames / ephemeral

A private-by-default, always-incognito browser for elementary OS
https://cassidyjames.com
GNU General Public License v3.0
154 stars 22 forks source link

[Feature request] Add the possibility to disable CSD #264

Closed Peter2121 closed 3 years ago

Peter2121 commented 3 years ago

When Ephemeral is used on non-GTK DE - il looks strange with client-side decoration (CSD) active by default. Please, add an option to disable it in Ephemeral's settings.

shot-2020-10-05_11-23-37

cassidyjames commented 3 years ago

This is not a matter of just "disabling" something, but would require significantly redesigning the app and maintaining two separate UIs for different platforms; something I am not willing to do personally, considering I maintain Ephemeral alone in my free time for elementary OS.

That said, what is the specific issue you have with the client-side decoration? Is the icon color wrong here? If so, that has nothing to do with CSD and is more likely an issue with either the in-app CSS or the GTK theme your system is using. How do other GNOME/GTK apps look on your system?

Peter2121 commented 3 years ago

That said, what is the specific issue you have with the client-side decoration?

How do other GNOME/GTK apps look on your system?

Leferea: liferea

Geany: geany

Ephemeral (started normally): ephemeral-csd

Ephemeral (started using gtk3-nocsd): ephemeral-nocsd

Geany and Liferea are GTK3 applications, started normally. They have a correct look, respecting the current WM that provides windows decorations. To get the same behavior with Ephemeral I use gtk3-nocsd. I hope you will be able to use the same approach as the one used by gtk3-nocsd developers to disable CSD automatically in non-GNOME WMs (or just add such option in Ephemeral's parameters so the user can choose if he wants CSD or not).

cassidyjames commented 3 years ago

As stated in the README, Ephemeral is designed and developed exclusively for elementary OS. If other environments want to do something different with GTK3 apps using headerbars, it's up to those environments to implement something like gtk3-nocsd—for what it's worth, my brief tests of Ephemeral on Manjaro seemed to imply Manjaro is doing that, or their compositor somehow works differently and places a server-side titlebar on top of the Ephemeral window as users of that OS might expect.

I don't have the time or interest to do extra work to support other environments.