search

cassidyjames / ephemeral

A private-by-default, always-incognito browser for elementary OS
https://cassidyjames.com
GNU General Public License v3.0
154 stars 22 forks source link

Ephemeral does not remember dark preference #265

Open janxkoci opened 3 years ago

janxkoci commented 3 years ago

After the recent update to 7.0.4, the browser does not remember the setting for dark preference - new window is always created with this setting off. Previous versions remembered my last choice.

All other settings are remembered, such as zoom level or default search engin.

PS: I'm on elementary OS Hera, so I don't have any system-wide setting for dark preference.

cassidyjames commented 3 years ago

Yep, this was a (knowing) regression to get the support for elementary OS 6 dark style shipping; it defaults to the system style and then allows a temporary override. I can look into bringing back a permanent override that interoperates with the dark style preference, but it gets more complex pretty quickly.

janxkoci commented 3 years ago

That makes sense. However my system (elementary OS 5) doesn't have any preference for dark style. Could it be detected? Maybe the permanent override could kick in only if the system doesn't send any signal for dark/light style preference?

cassidyjames commented 3 years ago

@janxkoci yep, exactly; that will work on elementary OS 5 and anything other than elementary OS 6.