search

cassidyjames / ephemeral

A private-by-default, always-incognito browser for elementary OS
https://cassidyjames.com
GNU General Public License v3.0
153 stars 21 forks source link

Trouble with switching layout #266

Open logdimov opened 4 years ago

logdimov commented 4 years ago

Hello. Found the problem: The search bar is cleared when switching layouts if I enter a query in two languages.

janxkoci commented 4 years ago

You mean changing keyboard layout language with Shift+Alt? It does clear text I type into the address/search bar when I press the key combo, so if you meant that, I can also reproduce it.

logdimov commented 4 years ago

You mean changing keyboard layout language with Shift+Alt? It does clear text I type into the address/search bar when I press the key combo, so if you meant that, I can also reproduce it.

Hello. Yes, I'm talking about this problem.

cassidyjames commented 4 years ago

Thanks for reporting this! It looks like I reset the UrlEntry when it loses focus:

https://github.com/cassidyjames/ephemeral/blob/bb775debde3c48cdf4b3c58d2ec3de90c03bba83/src/Widgets/UrlEntry.vala#L118-L130

...and changing layouts causes it to lose focus. I can revisit this and see what other browsers do.

janxkoci commented 4 years ago

I just realized this also happens when I alt+tab into another app and back, e.g. when I try to retype some search terms from somewhere (maybe a photo or other source without easy copy-paste).

I can revisit this and see what other browsers do.

Both Epiphany and Firefox keep the typed text, although they both stop showing suggestions etc, after I alt+tab away and back.