cassidyjames / ephemeral

A private-by-default, always-incognito browser for elementary OS
https://cassidyjames.com
GNU General Public License v3.0
154 stars 21 forks source link

Fixed some translations #92

Closed NathanBnm closed 5 years ago

NathanBnm commented 5 years ago

Changelog

Problems

Please update others translations files than fr.po from the com.github.cassidyjames.ephemeral.pot file to add the missing strings (I don't know how to do it for all the files at the same time).

I found an error when I checked translations at line 42 in UrlEntry.vala file:

secondary_icon_tooltip_markup = Granite.markup_accel_tooltip ({"Return"}, secondary_icon_tooltip_text);

I think that "Return" isn't the correct string. I saw the French translation in app but it doesn't make sense. Can you check ?

cassidyjames commented 5 years ago

@NathanBnm regarding "Return," that's actually handled by the Granite library and should be interpreted as the "Enter" key. It's possible this update has not been released yet, so you'd still be seeing "Return" in the tooltip: https://github.com/elementary/granite/blob/23d264e1a6d25fcd5770b0607179928763beadee/lib/Widgets/Utils.vala#L133

cassidyjames commented 5 years ago

@NathanBnm ah yeah, the latest Granite release is 5.2.2 from December, but that was fixed in Granite in January.