search

cassidymwagner / fluidsf

FluidSF is a package used to calculate structure functions from fluid data.
https://cassidymwagner.github.io/fluidsf
MIT License
5 stars 3 forks source link

Bug fix for longitudinal/meridional calculation #26

Closed BrodiePearson closed 2 months ago

BrodiePearson commented 2 months ago

This PR fixes a bug where LL, LLL and LSS (all longitudinal structure functions except LTT) use u as the longitudinal velocity and v as the transverse velocity, even when the separation is in the y-direction.

This PR corrects the core code to use the correct velocity components for meridional separations. @cassidymwagner could you assist in correcting the tests where needed!

UPDATE: I merged it into the 2D map branch, and it matches the 2D map calculations, so I think the calculation itself is correct. Just the tests that may need updating.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.16%. Comparing base (3acfbdf) to head (b326bdd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #26 +/- ## ========================================== + Coverage 99.13% 99.16% +0.02% ========================================== Files 8 8 Lines 232 239 +7 ========================================== + Hits 230 237 +7 Misses 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

BrodiePearson commented 2 months ago

Great, merge whenever you are ready!