cassidymwagner / fluidsf

FluidSF is a package used to calculate structure functions from fluid data.
https://cassidymwagner.github.io/fluidsf
MIT License
5 stars 3 forks source link

Array shifting bug fix #27

Closed cassidymwagner closed 2 months ago

cassidymwagner commented 2 months ago

This PR will fix a bug that shifted the arrays in an inconsistent direction, resulting in flipped signs for some of the structure functions. I'm also including updated tests (WIP) that evaluate the code against analytical solutions, which will be a more robust method of testing.

TODO:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 99.08257% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.58%. Comparing base (5a5201f) to head (ff05488).

Files Patch % Lines
fluidsf/generate_structure_functions.py 98.52% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## ========================================== + Coverage 99.16% 99.58% +0.42% ========================================== Files 8 8 Lines 239 242 +3 ========================================== + Hits 237 241 +4 + Misses 2 1 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.