Intro to iOS CodePath Assignment #3 - Twitter client

[cassiomo]

My App is not able to be completed. Please review /cc @codepath /cc @codepathreview /cc @thecodepath

I am not able to complete the required feature on time....

[codepathreview]

All right, I played with your half finished app for a while. There is something weird going on before Twitter auth, you see the timeline already show up and then Safari being opened. You trigger the loginSegue twice. This is because first you trigger it because it is hooked up to the Login with Twitter button, whereas this should not be the case. Then after a successful login, you trigger it via the code a second time.

Delete theloginSegue, and create it from the View Controller to the NavigationController. Right click - drag like here: http://stackoverflow.com/questions/21205485/ios7-segue-and-storyboards-how-to-create-without-a-button. Call it loginSegue again and you should be good. Lots of autolayout work to do though :)

I suggest you finish the app a bit more, next week we do a more polished version of a twitter client and then it is handing to have this one finished.

-- dirk

[cassiomo]

Thanks, will do!

[codepathreview]

:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:

• You should declare all unnecessarily public properties as private for better encapsulation.
• Your layouts are not perfect on a bigger phone
• You shoud try setting up the controls within the Tweet cells. It can sometimes be hard to have a clean design for embedded controls because it usually involves cumbersome plumbing. This is an instance where I think having the model handle the network action helps greatly simplify the implementation.
• You should try implementing the post tweet insertion into the feed. In real MVC apps, the more polished experiences have to do a certain amount of local object management to make a fully seamless experience.

In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.

-- dirk

[cassiomo]

Thanks for a lot for the valuable comment.!!