castacks / castacks.github.io

AirLab's website source
https://theairlab.org
MIT License
6 stars 17 forks source link

Every click in some pages opens a new tab. #37

Closed bradygm closed 3 years ago

bradygm commented 4 years ago

Without realizing it, you suddenly have 10 tabs of theairlab.org. Pretty cool, but kind of spammy.

keipour commented 4 years ago

It's not an issue. It automatically converts all the links to new-tab links if you add link-new-tab: true at the top of the post. Basically these posts here have it: https://github.com/castacks/website-dev/search?q=link-new-tab&unscoped_q=link-new-tab Arguably some posts that have it right now don't need it, but I think it's the author's job to decide on their post.

bradygm commented 3 years ago

The issue is that it opens a new tab even when navigating within our own website and not just for external links.

keipour commented 3 years ago

Fixed now. Closing the issue.