search

castagna / hbase-rdf

Apache License 2.0
24 stars 9 forks source link

Updated code #4

Closed vaibhavkhadilkar closed 13 years ago

vaibhavkhadilkar commented 13 years ago

Hi Paolo,

I've added the following things:

  1. Pluggable layouts.
  2. Vertical partitioning layout.
  3. Updated junit tests.
  4. Fixed some bugs.

There are a number of commit requests because I was trying to align the structure correctly.

castagna commented 13 years ago

Hi Vaibhav, I've just merged your changes (even if I had problems and a lot of conflicts). However, the testing directory is missing... please, commit it. You can make changed directly to the master branch in the hbase-rdf repo.

vaibhavkhadilkar commented 13 years ago

Hi Paolo,

I dont understand which testing folder you mentioned. In the newer version, all tests have now been moved under src/test. The folder src/main only contains the sources while src/examples contains a couple of example usages for the two layouts.

Thanks, Vaibhav.

On Fri, May 20, 2011 at 11:36 AM, castagna < reply@reply.github.com>wrote:

Hi Vaibhav, I've just merged your changes (even if I had problems and a lot of conflicts). However, the testing directory is missing... please, commit it. You can make changed directly to the master branch in the hbase-rdf repo.

Reply to this email directly or view it on GitHub: https://github.com/castagna/hbase-rdf/pull/4#issuecomment-1211002

castagna commented 13 years ago

See: https://github.com/castagna/hbase-rdf/blob/master/src/test/java/com/talis/hbase/rdf/test/HBaseRdfTestSetup.java

... where is the "testing/" directory?

vaibhavkhadilkar commented 13 years ago

Got it, It is done.

On Fri, May 20, 2011 at 1:52 PM, castagna < reply@reply.github.com>wrote:

See: https://github.com/castagna/hbase-rdf/blob/master/src/test/java/com/talis/hbase/rdf/test/HBaseRdfTestSetup.java

... where is the "testing/" directory?

Reply to this email directly or view it on GitHub: https://github.com/castagna/hbase-rdf/pull/4#issuecomment-1211783