castai / k8s-agent

Apache License 2.0
61 stars 15 forks source link

Enable detection of custom deployment CRD's (argo-rollouts) #81

Closed Temikus closed 1 year ago

Temikus commented 2 years ago

We use some custom deployment CRD’s (argo rollouts - Rollout) to drive our workloads - is it possible to include those into cost reporting? They answer to all the same API’s as Deployment does - they’re just an extension.

Here's a spec: https://argoproj.github.io/argo-rollouts/features/specification/

Minimal example:

apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  name: rollouts-demo
spec:
  replicas: 5
  strategy:
    canary:
      steps:
      - setWeight: 20
      - pause: {}
      - setWeight: 40
      - pause: {duration: 10}
      - setWeight: 60
      - pause: {duration: 10}
      - setWeight: 80
      - pause: {duration: 10}
  revisionHistoryLimit: 2
  selector:
    matchLabels:
      app: rollouts-demo
  template:
    metadata:
      labels:
        app: rollouts-demo
    spec:
      containers:
      - name: rollouts-demo
        image: argoproj/rollouts-demo:blue
        ports:
        - name: http
          containerPort: 8080
          protocol: TCP
        resources:
          requests:
            memory: 32Mi
            cpu: 5m
mjur-cast commented 2 years ago

@Temikus - hey, apologies for not responding earlier. Thank you, I've added this feature to our roadmap for future prioritisation. We are busy with the Q3 planned work, but will let you know the ETA as soon as we have it.

mjur-cast commented 2 years ago

@Temikus - hi! we did add the support for CRDs in to cost reporting. please check

UndeadRat22 commented 1 year ago

Done.