search

castcollab / tesserae2

Tesserae2: Fast recombination-aware global and local alignment.
Other
3 stars 0 forks source link

Black and Pylint don't have the same rules for hanging indentation blocks #30

Closed jonn-smith closed 4 years ago

jonn-smith commented 4 years ago

When tidying up my code with the new tools ala: black src tests && flake8 src tests && pylint src

Pylint still gives me warnings about spacing for the indentation blocks:

…
src/tesserae/tesserae.py:107:0: C0330: Wrong hanging indentation before block (add 4 spaces).
        self,
        ^   | (bad-continuation)
src/tesserae/tesserae.py:108:0: C0330: Wrong hanging indentation before block (add 4 spaces).
        mem_limit=False,
        ^   | (bad-continuation)
src/tesserae/tesserae.py:109:0: C0330: Wrong hanging indentation before block (add 4 spaces).
        pdel=DEFAULT_DEL,
        ^   | (bad-continuation)
src/tesserae/tesserae.py:110:0: C0330: Wrong hanging indentation before block (add 4 spaces).
...

I think the rules in black and pylint need to be reviewed together so they mesh better.

winni2k commented 4 years ago

I disabled these messages in the tox.ini file (i.e. when you run tox -e lint), but the correct thing to do is to move the disables into .pylintrc so they can be found by pylint however it is run.