Closed winni2k closed 4 years ago
We should annotate all function arguments and return types going forward.
This has become quite a substantial PR, so in order to avoid lots of merge conflicts going forward, I am keen to get this merged quickly.
I am also quite excited about mypy now. In 61f1f2a it allowed me to detect a mismatch between the documentation of a method and what the method was actually doing.
I renamed Sequence
because that is already a class in the python typing system/collections
. I thought it would avoid confusion in the future to use something else.
I have squashed and rebased onto master. I will merge this on Friday morning unless I get comments by then.
Closes #19
One particular question for review: Are we removing assert statements of types now that we are using mypy for typing instead? I think that that could work.