Fix for fuzzylogic if WOA is missing in a location

castelao / CoTeDe

Quality Control of Oceanographic Data

https://cotede.readthedocs.io

BSD 3-Clause "New" or "Revised" License

48 stars 17 forks source link

Fix for fuzzylogic if WOA is missing in a location #30

Closed s-good closed 8 years ago

s-good commented 8 years ago

The fuzzy logic QC test requires the woa_normbias entry in the features dictionary but this is not present if woa is None or the data are missing, which I think can then trigger a failure. This is an attempt to fix this.

s-good commented 8 years ago

Hi @castelao, sorry to push you but just wondering if it would be possible to merge this if it looks OK?

castelao commented 8 years ago

Don't worry @s-good.

This was fixed way back earlier this year, and is available in the dev branch. Please let me know if that works for you.

This fix and others were supposed to be updated few months ago when I tried some PR into AutoQC. While waiting for that PR approval, I got busy in the way. Looks like we're out of phase. Sorry about that.

s-good commented 8 years ago

Thanks @castelao, will delete this pull request now.