search

castelao / CoTeDe

Quality Control of Oceanographic Data
https://cotede.readthedocs.io
BSD 3-Clause "New" or "Revised" License
48 stars 17 forks source link

Error in fuzzylogic notebook #72

Closed alkis05 closed 1 year ago

alkis05 commented 1 year ago

This is probably abandoned, but there is a mistake in the fuzzy_logic.ipnb where the fuzzy functions are generated.

for each line, where there is something like: data['spike_lo'] = fuzz.zmf(data['x_spike'], cfg['fuzzylogic']['features']['spike']['low'])

it should be: data['spike_lo'] = fuzz.zmf(data['x_spike'], cfg['fuzzylogic']['features']['spike']['low']['params'])

So the parameters of the z-membership function are loaded properly. The author probably modified load_cfg and forgot to update the notebook.

castelao commented 1 year ago

Thanks!