Nr/cm custom previews - Githubissues

castiron / manifold-marketing

0 stars 0 forks source link

Nr/cm custom previews #128

Open naomiyaki opened 6 years ago

naomiyaki commented 6 years ago

This branch adds custom previews in the backend for the following content elements:

One Button Hero
One Button Callout
Multi-Button Callout
Animated Callout

edit page octobercms 2018-02-09 12-02-22

Note that these features require the 4.3 branch (not the tag/version) of contentment-plugin, and the latest version of the webpackassets-plugin (1.0.6 at this time).

zdavis commented 6 years ago

Hey @naomiyaki is this still a valid PR? We updated contentment yesterday to the most recent version. I can accept this, but want to make sure it's still the right solution.

naomiyaki commented 6 years ago

@zdavis If contentment was updated, I can rebase and test - everything should work just peachy with new contentment, and then I'll squash and update the PR for your perusal!

zdavis commented 6 years ago

Sounds good. Thanks.

naomiyaki commented 6 years ago

@zdavis this is updated and working on my end, but there are a few contentment errors that I want to look at with @lthurston when he gets in just to make sure we're on top of it and that it isn't some kind of regression from this work.

naomiyaki commented 6 years ago

@lthurston I never got a chance to go through this with you! Can you just QA and make sure contentment is working, then poosh?

zdavis commented 6 years ago

Lucas, could you help close the loop on this? I've been unable to pull this PR in for a while, and there is in fact some kind of regression. I've rebased this branch on Master, which is using the same version of contentment. In this branch, trying to create any content element fails with an error. I can't trace the error because of Contentment's reliance on Rollbar without requiring it properly (see castiron/contentment-plugin#48).

lthurston commented 6 years ago

Acknowledged. I'll review and get it working.