search

castiron / manifold-marketing

0 stars 0 forks source link

Fix slug handling for contentment pages flagged as root #89

Closed blnkt closed 7 years ago

blnkt commented 7 years ago

Blocking #88 I will go ahead and address #88 but I don't think it's right that you have to have a slug on the parent (i.e. that urls look like /home/child but they should look like /child) so I'm handing that part off to @gblair . @zdavis chime in if you would prefer the homepage to have a slug when it is a parent page and I will banish this issue from whence it came

blnkt commented 7 years ago

See pull request #90 ; Branch bm/navigation

zdavis commented 7 years ago

@gblair Were you able to make any headway on this yesterday?

gblair commented 7 years ago

@zdavis sorry I was delayed on this. I have a fix in a Contentment branch, but I'm not sure how we should handle non-site-root top-level pages with that approach. I suppose they might function normally, but it will take a little creative thinking to make that happen. I want to talk that through with you or Lulu before we lock it in. In the mean time, I've delivered a patch (fe3f536) to @blnkt 's branch (re: #90) that should at least allow the nav to be generally generated from the set of existing pages (sans the site_root).

zdavis commented 7 years ago

Let's discuss today. Thanks!