castlabs / electron-releases

castLabs Electron for Content Security
https://castlabs.com/resources/downstream/
MIT License
222 stars 41 forks source link

electron-updater autoUpdater.quitAndInstall() don't relaunch. #140

Open eloypr opened 1 year ago

eloypr commented 1 year ago

I create a quasar-vite scaffold for electron and electron-updater with electron-builder package (AppImage in Linux) work fine with electron original, i changed to castlabs/electron, the autoupdater work fine on download new version and can't relaunch with newer version.

quasar: 2.6.0 castlabs/electron: 21.2.3+wvcus electron-updater: 5.3.0 electron-builder: 23.6.0

Thank you.

khwaaj commented 1 year ago

Without more details on how it fails I'm not sure I can be of much help. Generally speaking you should not be seeing any differences in behavior between stock Electron and ECS, except that you are effectively waiting for the CDM to become available the you call components.whenReady().

For the issue that you are seeing, what is the effect of the update in more detail? The old instance quits and tries to relaunch, but hangs? Fails to execue at all with some error? Something else?

eloypr commented 1 year ago

I don't have much information either, there is no error message, it just closes the old instance and doesn't relaunch, there is no indication of a crash.

The output messages log are:

New version 0.0.9 has been downloaded to /home/user/.cache/app/pending/app-0.0.9.AppImage
Update downloaded; will install in 5 seconds.
Install on explicit quitAndInstall
Install: isSilent: false, isForceRunAfter: true
Update installer has already been triggered. Quitting application.

Stopped working when changing Electron to ECS, even the components.whenReady() call.

Thanks for trying

khwaaj commented 1 year ago

But the updated version is possible to launch manually?

eloypr commented 1 year ago

Yes