search

castlabs / electron-releases

castLabs Electron for Content Security
https://castlabs.com/resources/downstream/
MIT License
225 stars 43 forks source link

Postinstall 404 #186

Open jtvberg opened 2 months ago

jtvberg commented 2 months ago

I am getting this error on package install:

[4/4] Building fresh packages...
error ~/node_modules/electron: Command failed.
Exit code: 1
Command: node install.js
Arguments: 
Directory: ~/node_modules/electron
Output:
HTTPError: Response code 404 (Not Found)
    at Request._onResponseBase (~/node_modules/got/dist/source/core/index.js:913:31)
    at Request._onResponse (~/node_modules/got/dist/source/core/index.js:948:24)
    at ClientRequest.<anonymous> (~/node_modules/got/dist/source/core/index.js:962:23)
    at Object.onceWrapper (node:events:635:26)
    at ClientRequest.emit (node:events:532:35)
    at origin.emit (~/node_modules/@szmarczak/http-timer/dist/source/index.js:43:20)
    at HTTPParser.parserOnIncomingClient (node:_http_client:704:27)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:118:17)
    at TLSSocket.socketOnData (node:_http_client:546:22)
    at TLSSocket.emit (node:events:520:28)

Both npm and yarn fail on the same step (I cleaned the npm cache, deleted the node_modules directory and lock file between every try of this.) If I go into the node_modules/electron directory and yarn run postinstallor node install.js I get the same.

HTTPError: Response code 404 (Not Found)
    at Request._onResponseBase (~/node_modules/got/dist/source/core/index.js:913:31)
    at Request._onResponse (~/node_modules/got/dist/source/core/index.js:948:24)
    at ClientRequest.<anonymous> (~/node_modules/got/dist/source/core/index.js:962:23)
    at Object.onceWrapper (node:events:635:26)
    at ClientRequest.emit (node:events:532:35)
    at origin.emit (~/node_modules/@szmarczak/http-timer/dist/source/index.js:43:20)
    at HTTPParser.parserOnIncomingClient (node:_http_client:704:27)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:118:17)
    at TLSSocket.socketOnData (node:_http_client:546:22)
    at TLSSocket.emit (node:events:520:28)

At first, digging around the posted issues I thought it was a git ssh issue as this did not work: git --no-replace-objects ls-remote ssh://git@github.com/castlabs/electron-releases.git as ssh -T git@github.com was being denied But I generated a key, and now it works and returns the list along with the specific version I am targeting: 0a7b46f1b1300e4282f6dca0ee26f7e856141ccc refs/tags/v32.1.0+wvcus

The same exact package.json install works on MacOS and Windows without issue with the same versions of Node and npm (I don't typically use yarn at all. Just tried it to see if it helped.) It also used to work previously on linux Mint (which I used for testing before I switched to Ubuntu.) Here are my dependencies:

  "devDependencies": {
    "@electron/notarize": "^2.4.0",
    "electron": "github:castlabs/electron-releases#v32.1.0+wvcus",
    "electron-builder": "^25.0.5",
    "electron-reloader": "^1.2.3"
  },
  "dependencies": {
    "@fortawesome/fontawesome-free": "^6.6.0",
    "electron-updater": "^6.3.4"
  }

Environment: OS: Ubuntu 24.04 Node: 22.8.0 npm: 10.8.3

I promise I have sufficiently banged my head on a wall and reviewed everything I could find under issues here or with git ssh, but I am at a loss. (To be clear, I don't see how this is a ssh problem, I just saw that in a recent issue and wanted to cover my bases.)

I would very much appreciate any insight!

andymartinwork commented 1 month ago

This has been happening to me as well, on a fresh install of windows 11. I'm not getting this error on an existing install. Electron itself has no problem. It's only the castlabs version.

The problem is happening on both NPM and Yarn.

git --no-replace-objects ls-remote ssh://git@github.com/castlabs/electron-releases.git Has no problem with running.

Unfortunately I haven't been able to fix this either.

Environment: OS: Windows 11 Node: v20.17.0

slosacoder commented 1 month ago

@jtvberg have you managed to fix this??

jtvberg commented 1 month ago

Nope. Out of ideas

khwaaj commented 1 month ago

For the record, I've been trying to reproduce this several times without success (including a retry now tonight). This was done on an environment mirroring the initially reported one:

Ubuntu 24.04 / x64 Node: 22.9.0 NPM: 10.8.3

So I'm inclined to believe there is some environmental factor at work here, but it is very hard to tell what. I tried in a couple of smaller projects, adding the dependencies listed, but everything is just working without issue... 🤷‍♂️

Can you tell what is being requested when you get the 404? E.g. if you run DEBUG="*" node install.js, does it show anything relevant (after making sure the cache is cleared)?

slosacoder commented 1 month ago

It definetly is an environmental issue, ive build my program just fine 24/9 on a fresh install of ubuntu 24.10, but then i switched my environment to Fedora 41 and i also tried on Ubuntu 22.04, but unfortunately with no luck and the same error occuring same time

  @electron/get:index Cache miss +7ms
  @electron/get:index Downloading https://github.com/castlabs/electron-releases/releases/download/v30.0.4+wvcus/electron-v30.0.4+wvcus-linux-arm64.zip to /tmp/electron-download-fNNm1z/electron-v30.0.4+wvcus-linux-arm64.zip with options: undefined +46ms
HTTPError: Response code 404 (Not Found)
    at Request._onResponseBase (/home/ubuntu/Cider/node_modules/@electron/get/node_modules/got/dist/source/core/index.js:913:31)
    at Request._onResponse (/home/ubuntu/Cider/node_modules/@electron/get/node_modules/got/dist/source/core/index.js:948:24)
    at ClientRequest.<anonymous> (/home/ubuntu/Cider/node_modules/@electron/get/node_modules/got/dist/source/core/index.js:962:23)
    at Object.onceWrapper (node:events:628:26)
    at ClientRequest.emit (node:events:525:35)
    at ClientRequest.origin.emit (/home/ubuntu/Cider/node_modules/@electron/get/node_modules/@szmarczak/http-timer/dist/source/index.js:43:20)
    at HTTPParser.parserOnIncomingClient (node:_http_client:693:27)
    at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
    at TLSSocket.socketOnData (node:_http_client:534:22)
    at TLSSocket.emit (node:events:513:28)

this is the output, after DEBUG="*" node install.js Ubuntu 22.04 / arm64 Node 16.20.1 npm 8.19.4

khwaaj commented 1 month ago

@slosacoder, in this case it is actually pretty clear what the issue is: ECS only supports linux-x64. Since there are no official CDMs for any of the ARM architectures of Linux we simply can't support them, so the 404 error is very spot on. When you say it worked on 24/9, I suppose that was on a x64 based VM or machine, or with stock Electron (which supports ARM configurations)?

I'm not sure if this is the explanation for all cases above, as the architecture seems to have been left out of the reports?

slosacoder commented 1 month ago

Hi, sorry im replying via an email, but i dont have access to github at this moment. Yes, that would make sense i was trying to build it on my arm-based VPS, but how i said i got the same error even on my main x64 fedora workstation, strangely it did work on ubuntu 24.10 (also x64) few weeks ago, ill share the debug log from npm install when i get on there. PS: The outdated nodejs and npm version are due to the program im building not supporting newer ones, but how i said, that shouldnt be the issue because i built it just fine on 24/9 Thanks in advance!

Dne so 5. 10. 2024 11:11 uživatel Emil Pettersson @.***> napsal:

@slosacoder https://github.com/slosacoder, in this case it is actually pretty clear what the issue is: ECS only supports linux-x64. Since there are no official CDMs for any of the ARM architectures of Linux we simply can't support them, so the 404 error is very spot on. When you say it worked on 24/9, I suppose that was on a x64 based VM or machine, or with stock Electron (which supports ARM configurations)?

I'm not sure if this is the explanation for all cases above, as the architecture seems to have been left out of the reports?

— Reply to this email directly, view it on GitHub https://github.com/castlabs/electron-releases/issues/186#issuecomment-2394991079, or unsubscribe https://github.com/notifications/unsubscribe-auth/BIN3JVRECCMNIGI7UHUMQGDZZ6ULRAVCNFSM6AAAAABOJ4YTQWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJUHE4TCMBXHE . You are receiving this because you were mentioned.Message ID: @.***>