castlecms / castle.cms

A product of Wildcard Corp. https://wildcardcorp.com
https://castlecms.io
GNU General Public License v2.0
35 stars 17 forks source link

Secure login view breaking #201

Closed obct537 closed 6 years ago

obct537 commented 6 years ago

While logging in with two factor enabled, I'm getting a view template error: `2018-09-10 20:05:22 ERROR Zope.SiteErrorLog 1536609922.970.638547358464 http://10.0.2.2:8080/@@secure-login Traceback (innermost last): Module ZPublisher.Publish, line 138, in publish Module ZPublisher.mapply, line 77, in mapply Module ZPublisher.Publish, line 48, in call_object Module castle.cms.browser.login, line 58, in call Module Products.Five.browser.pagetemplatefile, line 125, in call Module Products.Five.browser.pagetemplatefile, line 59, in call Module zope.pagetemplate.pagetemplate, line 132, in pt_render Module five.pt.engine, line 98, in call Module z3c.pt.pagetemplate, line 163, in render Module chameleon.zpt.template, line 261, in render Module chameleon.template, line 191, in render Module chameleon.template, line 171, in render Module cb6ca5564a3be8b358be930775598864.py, line 508, in render Module five.pt.expressions, line 161, in call Module castle.cms.browser.login, line 385, in options Module plone.protect.authenticator, line 95, in createToken SystemError: error return without exception set

This only happens after submitting the login attempt, and the login session is actually created, but the login page only shows and error and doesn't redirect

CorySanin commented 6 years ago

Attempted login from /Castle/@@secure-login with 2FA enabled and successfully redirected to dashboard. Chrome and Firefox both work. Using email for authentication. I can't seem to reproduce this.

obct537 commented 6 years ago

As I reread this, realize I forgot to mention that this is happening when I'm trying to log into the zope root (aka like at localhost:8080/manage). That might make a difference?

CorySanin commented 6 years ago

Tried that too, just in case. That also redirects as it should, though it redirects back to the root index instead of the user dashboard.

CorySanin commented 6 years ago

Probably forgot to perform upgrade step- probably not an issue 👌